Add support for HTTP Streaming #2140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 3f9f336No changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Dec 8, 2024
| statusText | ||
| // If the promise fails, make sure the stream is closed | ||
| readPromise.catch((e) => { | ||
| console.error('error reading body', e) |
There was a problem hiding this comment.
do we really need to console.error here? won't controller.error be enough?
|
|
||
| let res = Arc::into_inner(res).unwrap().0; | ||
| Ok(tauri::ipc::Response::new(res.bytes().await?.to_vec())) | ||
| let mut stream = res.bytes_stream(); |
There was a problem hiding this comment.
can't we do the same streaming behavior using Response::chunk method, instead of pulling another crate to iterate over the stream?
|
positive results on discord: https://discord.com/channels/616186924390023171/1344666371316908063 (not rushing anyone, i still think the review comments need to be acknowledged) |
|
hello, is there any progress on this PR? Waiting for it to enable LLM streaming |
|
still waiting on reactions to the review comments 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the internals of the fetch implementation such that
fetch_read_bodyuses theChannelAPI to stream http responses instead of waiting for the entire response to finish and then returning the final ArrayBuffer.Two things to note:
The
Channel<&[u8]>type is serializing as anumber[]instead ofArrayBufferorUint8Array. I'm not certain that the Channel supports serializing asArrayBuffers? I think this could be a possible performance improvement.The
ChannelAPI implementation does not guarantee that all events are received by the time theinvokepromise is resolved. This is unfortunate, but I worked around it by returning an empty array over theChannelwhich is used to close theReadableStream. I think this design works alright, but maybe there's a cleaner way to do this.Fixes #2129